http3: turning support up by default#1717
Merged
Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
junr03
reviewed
Sep 21, 2021
| build --features=-per_object_debug_info | ||
| # Suppress deprecated declaration warnings due to extensive transitive noise from protobuf. | ||
| build --copt -Wno-deprecated-declarations | ||
| build --@envoy//bazel:http3=False |
Member
There was a problem hiding this comment.
can we add this to release-common so that our release builds don't yet include it?
Contributor
Author
There was a problem hiding this comment.
will this mean we have to exempt quic tests from the release build somehow?
doable but it may make more sense to have this as a lyft-only thing, WDYT?
Member
There was a problem hiding this comment.
talked offline. Happy to not compile h3 in our private build.
junr03
approved these changes
Sep 21, 2021
| build --features=-per_object_debug_info | ||
| # Suppress deprecated declaration warnings due to extensive transitive noise from protobuf. | ||
| build --copt -Wno-deprecated-declarations | ||
| build --@envoy//bazel:http3=False |
Member
There was a problem hiding this comment.
talked offline. Happy to not compile h3 in our private build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a 15% binary size bump, but hey, HTTP/3 support!
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes: